Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(main): release java-function-invoker 1.3.1 #237

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

garethgeorge
Copy link
Contributor

Reattempt java-function-invoker 1.3.1 release.

@garethgeorge garethgeorge changed the title Reapply "chore(main): release java-function-invoker 1.3.1 (#220)" (#236) chore(main): release java-function-invoker 1.3.1 Sep 22, 2023
@conventional-commit-lint-gcf
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@kenneth-rosario
Copy link
Contributor

@garethgeorge Another release please pr was created for v1.3.1: #234

Which should we merge?

@garethgeorge
Copy link
Contributor Author

garethgeorge commented Sep 25, 2023

Good catch, thanks Kenneth. This one includes fixes and should be merged -- we can safely close the other if the release works this time.

An alternative would be patching the fixes in this PR into the release-please bot's new PR. Happy to defer to either approach if you have a preference w.r.t. which seems safer.

@kenneth-rosario
Copy link
Contributor

Lets use this one. The only thing is the release job will need to be triggered manually but that should be straight forward.

@garethgeorge garethgeorge merged commit 6dfc3c7 into main Sep 26, 2023
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants