fix: avoid executing function when /favicon.ico or /robots.txt is called #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
HKWinterhalter
approved these changes
Sep 28, 2023
|
Thank you! Just a simple doubt. Once the new version is released, how much time it may take to see the fix on production gcp? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change to fix #225.
As explained in the issue, the solution is based on other Jetty handlers: InetAccessHandler.java
Regarding tests, the integration tests were passing because they just check that 404 is returned, but they miss to check that function is not invoked.
I think that an extra test checking that part would be nice, but the current test framework API won't let me easily check that. I may extend a bit the test framework to add this test if you agree.