Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update [email protected] #24

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

atsushi-ishibashi
Copy link

@atsushi-ishibashi atsushi-ishibashi commented Jan 10, 2024

what I did

$ go get golang.org/x/[email protected]
go: upgraded github.com/golang/protobuf v1.4.2 => v1.5.3
go: upgraded github.com/google/go-cmp v0.5.8 => v0.5.9
go: upgraded golang.org/x/net v0.0.0-20200707034311-ab3426394381 => v0.19.0
go: upgraded golang.org/x/oauth2 v0.0.0-20200107190931-bf48bf16ab8d => v0.15.0
go: upgraded golang.org/x/sys v0.0.0-20200523222454-059865788121 => v0.15.0
go: upgraded golang.org/x/text v0.3.3 => v0.14.0
go: upgraded google.golang.org/appengine v1.6.6 => v1.6.7
go: upgraded google.golang.org/protobuf v1.25.0 => v1.31.0

background

I'd like to run Terraform on AWS Fargate with GCP Workload Identity Federation.
Config file downloaded from GCP Workload Identity has EC2 meta data url (ex. http://169.254.169.254/latest/meta-data/iam/security-credentials ) so I replaced them for ECS meta data url (ex. http://169.254.170.2/xxxxxxx).
But I got the below error message from Terraform.

oauth2/google: invalid hostname http://169.254.170.2/v2/credentials/xxxxxx for url

This change add validations.
golang/oauth2@ec4a9b2#diff-bdefc46963b0bfdcad1f8104b3ed32121ae459e5fa2008cc279b3b4f20ae17eaR270-R312
But the next remove them.
golang/oauth2@2d9e4a2

terraform-google-provider uses [email protected] (latest version)
https://github.com/hashicorp/terraform-provider-google/blob/858054bea2399d6e63302c009b34c39838adaf31/go.mod#L27

So updating oauth2 in this repository enables us to run Terraform on AWS Fargate.

contributing

While we appreciate your interest in the Declarative Client Library, due to the nature of the DCL we aren't able to accept community contributions.
If you'd like to contribute to Google Cloud's declarative configuration efforts, take a look at Terraform Provider Google, which makes use of the DCL.

This change must be in this repository so what am I supposed to do?

Copy link

google-cla bot commented Jan 10, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant