Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: round backoff in exponential backoff tests #1191

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

jackwotherspoon
Copy link
Collaborator

@jackwotherspoon jackwotherspoon commented Nov 14, 2024

We have seen the backoff value be microseconds below the low value causing test failures.

FAILED tests/unit/test_refresh_utils.py::test_exponential_backoff[0-324-524] - assert 323.97999248703616 >= 324

Rounding the answer to the nearest millisecond value will reduce flaky test.

Closes #1160

@jackwotherspoon jackwotherspoon self-assigned this Nov 14, 2024
@jackwotherspoon jackwotherspoon requested a review from a team as a code owner November 14, 2024 16:17
@jackwotherspoon jackwotherspoon merged commit aaa1ef3 into main Nov 19, 2024
15 checks passed
@jackwotherspoon jackwotherspoon deleted the jackwotherspoon-patch-1 branch November 19, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unit.test_refresh_utils: test_exponential_backoff[0-324-524] failed
2 participants