Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update type hints to standard collections #1183

Merged
merged 2 commits into from
Oct 25, 2024
Merged

chore: update type hints to standard collections #1183

merged 2 commits into from
Oct 25, 2024

Conversation

jackwotherspoon
Copy link
Collaborator

Updates type hints to use standard collections (list, tuple, dict).
We can do this now that Python 3.8 was removed

As of Python 3.9 and PEP 585 standard collections can be subscripted in
favor of their typing counterparts which are now deprecated.

@jackwotherspoon jackwotherspoon self-assigned this Oct 25, 2024
@jackwotherspoon jackwotherspoon requested a review from a team as a code owner October 25, 2024 15:07
@enocom enocom mentioned this pull request Oct 25, 2024
Open
@jackwotherspoon jackwotherspoon merged commit 5b245c6 into main Oct 25, 2024
15 checks passed
@jackwotherspoon jackwotherspoon deleted the typing branch October 25, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hessjcg hessjcg hessjcg approved these changes

Assignees

@jackwotherspoon jackwotherspoon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackwotherspoon @hessjcg