Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove pull_request_target trigger #1133

Merged
merged 4 commits into from
Jul 22, 2024

Conversation

jackwotherspoon
Copy link
Collaborator

Remove the need for tests: run label to trigger builds on PRs from external contributors.

@jackwotherspoon jackwotherspoon self-assigned this Jul 22, 2024
@jackwotherspoon jackwotherspoon requested a review from a team as a code owner July 22, 2024 14:21
.github/workflows/tests.yml Outdated Show resolved Hide resolved
- name: Checkout code
uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
with:
ref: ${{ github.event.pull_request.head.sha }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do these lines do? I left them in on AlloyDB.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these were used to just make sure the checkout from forks was pinned to the latest sha of the pull request.

@enocom enocom self-requested a review July 22, 2024 18:44
@jackwotherspoon jackwotherspoon merged commit cd0278d into main Jul 22, 2024
15 checks passed
@jackwotherspoon jackwotherspoon deleted the remove-pull-request-target branch July 22, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants