Scorecard - fixes for compatiblity with new config validator #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@briantkennedy Wasn't this meant to be fixed in GoogleCloudPlatform/config-validator#115? |
|
That's not 100% of it. I opened GoogleCloudPlatform/config-validator#116 to track the duplicate violation issue. It's quite vexing because I can't repro in rego unit tests and I'm only able to repro for the full end to end FCV setup when constraint framework is involved. |
morgante
reviewed
Feb 26, 2020
morgante
approved these changes
Mar 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes some issues in #584