Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scorecard - get real asset ancestry path #575

Merged
merged 13 commits into from
Feb 21, 2020
Merged

Scorecard - get real asset ancestry path #575

merged 13 commits into from
Feb 21, 2020

Conversation

katze120
Copy link
Contributor

@katze120 katze120 commented Feb 14, 2020

Get real asset ancestry path from CAI exports, so that:

  • "target" in the constraints can be effective
  • users can optionally output input.asset.ancestry_path in constraint templates as metadata

This PR obtains real input.asset.ancestry_path from CAI data and enables scorecard to output it in violation metadata if this is specified in constraint templates.

@katze120 katze120 closed this Feb 14, 2020
@katze120 katze120 reopened this Feb 14, 2020
Copy link
Contributor

@morgante morgante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking at this!

@briantkennedy Do you know when FCV will be a bit stabler?

cli/scorecard/violations.go Show resolved Hide resolved
cli/scorecard/violations.go Outdated Show resolved Hide resolved
cli/scorecard/violations.go Outdated Show resolved Hide resolved
@briantkennedy
Copy link
Member

FCV has a few more changes to go then it should be stable for quite a while

@morgante
Copy link
Contributor

@katze120 Looks like this needs a rebase.

@morgante morgante merged commit 461c549 into GoogleCloudPlatform:master Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants