Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dev-tools): make, not bash #2691

Merged
merged 2 commits into from
Nov 12, 2024
Merged

fix(dev-tools): make, not bash #2691

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7a7db3
Update Makefile
apeabody Nov 12, 2024
53f977f
Update build-push-cft-devtools.yml
apeabody Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/build-push-cft-devtools.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ jobs:
permissions:
contents: 'read'
id-token: 'write'
issues: 'write'

steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
Expand Down
5 changes: 1 addition & 4 deletions infra/build/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,10 +115,7 @@ build-image-developer-tools:

.PHONY: release-image-developer-tools
release-image-developer-tools:
if [[ -z "${GITHUB_SHA}" ]]; then
echo "ERROR: Missing GITHUB_SHA for the release"
exit 1
fi
test -n "$(GITHUB_SHA)" # $$GITHUB_SHA

docker tag ${DOCKER_IMAGE_DEVELOPER_TOOLS}:${DOCKER_TAG_VERSION_DEVELOPER_TOOLS} \
${REGISTRY_URL}/${DOCKER_IMAGE_DEVELOPER_TOOLS}:${DOCKER_TAG_VERSION_DEVELOPER_TOOLS}
Expand Down
Loading