Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support display metadata AlternateDefault validate #2661

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

q2w
Copy link
Collaborator

@q2w q2w commented Oct 18, 2024

This is a follow-up PR of #2453. The AlternateDefault value field is of type google.protobuf.Value. Similar to other fields of same type, it requires workaround so that JsonSchema doesn't treat it as object.

@q2w q2w changed the title chore: Update blueprint metadata json schema for DisplayVariable_AlternateDefault value feat: Support DisplayVariable AlternateDefault metadata validate Oct 18, 2024
@q2w q2w changed the title feat: Support DisplayVariable AlternateDefault metadata validate feat: Support display metadata AlternateDefault validate Oct 18, 2024
@q2w q2w marked this pull request as ready for review October 18, 2024 21:41
@q2w q2w requested a review from a team as a code owner October 18, 2024 21:41
Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @q2w!

@apeabody apeabody merged commit 295692f into GoogleCloudPlatform:master Oct 18, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants