fix: Version config path should look for versions.tf in current blueprint dirctory #2637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@qz267 PTAL! |
qz267
approved these changes
Oct 7, 2024
bharathkkb
approved these changes
Oct 7, 2024
|
@tjy9206 do we need to rerun the generate output type after ^^? |
I don't think so since the generated output types should have nothing to do with the version, but we should double check to confirm. Will try generating again when I get a chance to setup the overheads. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In blueprint metadata generation step, versions.tf needs to be loaded for generating version metadata.
Currently versions.tf file is being only searched in the root directory of the blueprint. This fails to generated version metadata for the submodules.
This feature was added in #2496