Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use -chdir in terraform_validate wrapper #2617

Merged
merged 1 commit into from
Sep 25, 2024
Merged

refactor: use -chdir in terraform_validate wrapper #2617

merged 1 commit into from
Sep 25, 2024

Conversation

wyardley
Copy link
Contributor

@wyardley wyardley commented Sep 25, 2024 •
edited
Loading

  • Use Terraform's -chdir option rather than cd

@wyardley
Copy link
Contributor Author

Docs generation is another place where I think the pushd / popd might not be needed and where the code might be simpler / more readable without it.

@apeabody
Copy link
Collaborator

/gcbrun

@wyardley wyardley changed the title fix: use -chdir and -upgrade in terraform_validate wrapper fix: use -chdir in terraform_validate wrapper Sep 25, 2024
@wyardley wyardley mentioned this pull request Sep 25, 2024
Open
@wyardley wyardley changed the title fix: use -chdir in terraform_validate wrapper refactor: use -chdir in terraform_validate wrapper Sep 25, 2024
@wyardley
Copy link
Contributor Author

updated the commit type to refactor, since it shouldn't change the behavior (ideally)

@apeabody
Copy link
Collaborator

/gcbrun

apeabody
apeabody requested changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@apeabody apeabody left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @wyardley!

Just to be safe/proper, let's bump the patch here: https://github.com/GoogleCloudPlatform/cloud-foundation-toolkit/blob/master/infra/build/Makefile#L59, and then this is ready to merge!

@wyardley
fix: use -chdir in terraform_validate wrapper
3efe333 
- Use Terraform's `-chdir` option rather than `cd`
@wyardley
Copy link
Contributor Author

Ok, and then bump the version in #2619 again after merge? Right now, they would both be at the same patch level.

@apeabody
Copy link
Collaborator

Ok, and then bump the version in #2619 again after merge? Right now, they would both be at the same patch level.

Exactly, a bit of extra work, but I'd like to get this PR merged/released today.

@apeabody
Copy link
Collaborator

/gcbrun

apeabody
apeabody approved these changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @wyardley!

@apeabody apeabody merged commit 9907e7f into GoogleCloudPlatform:master Sep 25, 2024
6 checks passed
apeabody added a commit that referenced this pull request Sep 25, 2024
@apeabody
Revert "refactor: use -chdir in terraform_validate wrapper (#2617)"
3290ae5 
This reverts commit 9907e7f.
@apeabody apeabody mentioned this pull request Sep 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apeabody apeabody apeabody approved these changes

@bharathkkb bharathkkb Awaiting requested review from bharathkkb bharathkkb is a code owner

@g-awmalik g-awmalik Awaiting requested review from g-awmalik g-awmalik is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wyardley @apeabody