Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add new alternate type for display variables and set ENABLE_BPMETADATA during CI test #2568

Merged
merged 3 commits into from
Sep 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
155 changes: 80 additions & 75 deletions cli/bpmetadata/bpmetadata_ui.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions cli/bpmetadata/proto/bpmetadata_ui.proto
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,8 @@ message DisplayVariable {
ALTERNATE_TYPE_UNSPECIFIED = 0;
// A more secure default.
ALTERNATE_TYPE_SECURITY = 1;
// A default specifically needed for Design center.
ALTERNATE_TYPE_DC = 2;
}
AlternateType type = 1; // @gotags: json:"type,omitempty" yaml:"type,omitempty"
// Value of the alternate default.
Expand Down
12 changes: 12 additions & 0 deletions infra/terraform/test-org/org/locals.tf
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,9 @@ locals {
description = "Deploys apps to Cloud Run, along with option to map custom domain"
owners = ["prabhu34", "anamer", "gtsorbo"]
topics = "cloudrun,google-cloud-platform,terraform-modules,${local.common_topics.serverless}"
lint_env = {
ENABLE_BPMETADATA = "1"
}
},
{
name = "terraform-google-secured-data-warehouse"
Expand Down Expand Up @@ -294,6 +297,9 @@ locals {
org = "terraform-google-modules"
description = "Creates one or more Cloud Storage buckets and assigns basic permissions on them to arbitrary users"
topics = local.common_topics.storage
lint_env = {
ENABLE_BPMETADATA = "1"
}
},
{
name = "terraform-google-composer"
Expand Down Expand Up @@ -422,6 +428,9 @@ locals {
description = "Creates a fully functional Google Memorystore (redis) instance"
topics = local.common_topics.db
owners = ["imrannayer"]
lint_env = {
ENABLE_BPMETADATA = "1"
}
},
{
name = "terraform-google-module-template"
Expand Down Expand Up @@ -486,6 +495,9 @@ locals {
description = "Creates a Cloud SQL database instance"
topics = local.common_topics.db
owners = ["isaurabhuttam", "imrannayer"]
lint_env = {
ENABLE_BPMETADATA = "1"
}
},
{
name = "terraform-google-startup-scripts"
Expand Down
Loading