Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add blueprint connections and related metadata #2440

Merged
merged 5 commits into from
Jul 8, 2024
Merged

Conversation

bharathkkb
Copy link
Member

No description provided.

@bharathkkb bharathkkb changed the title Add blueprint connections and related metadata feat: Add blueprint connections and related metadata Jul 1, 2024
@bharathkkb bharathkkb requested a review from q2w July 1, 2024 16:58
Copy link
Collaborator

@g-awmalik g-awmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the most part but a few concepts require a bit more description.

cli/bpmetadata/proto/bpmetadata.proto Show resolved Hide resolved
cli/bpmetadata/proto/bpmetadata_ui.proto Show resolved Hide resolved
@g-awmalik
Copy link
Collaborator

@njlisi - please review.

Copy link

@njlisi njlisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cli/bpmetadata/proto/bpmetadata_ui.proto Show resolved Hide resolved
@bharathkkb bharathkkb requested a review from g-awmalik July 3, 2024 02:57
@g-awmalik g-awmalik merged commit 608996c into master Jul 8, 2024
14 checks passed
@g-awmalik g-awmalik deleted the adc-bpmeta branch July 8, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants