Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(TF): reduce number of centralized labels #2103

Merged
merged 2 commits into from
Jan 26, 2024
Merged

chore(TF): reduce number of centralized labels #2103

merged 2 commits into from
Jan 26, 2024

Conversation

apeabody
Copy link
Collaborator

@apeabody apeabody commented Jan 25, 2024 •
edited
Loading

  • Reduce to a minimum number of mandatory centralized labels
  • IMPORTANT: Rather than removing existing labels, they must be removed only from TF state

@apeabody apeabody changed the title chore(TF): migrate to github_issue_labels chore(TF): migrate to new github_issue_labels Jan 25, 2024
@apeabody apeabody force-pushed the ap-fdsf8 branch 2 times, most recently from 60acf11 to 2ceae2b Compare January 26, 2024 00:08
@apeabody apeabody changed the title chore(TF): migrate to new github_issue_labels chore(TF): reduce number of centralized labels Jan 26, 2024
bharathkkb
bharathkkb approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments but non blocking

infra/terraform/test-org/github/labels.tf Show resolved Hide resolved
infra/terraform/test-org/github/labels.tf Outdated Show resolved Hide resolved
@apeabody
Copy link
Collaborator Author

applied - as the actual resources weren't removed they could always be re-added/imported if needed

@apeabody apeabody merged commit 0440660 into master Jan 26, 2024
6 checks passed
@apeabody apeabody deleted the ap-fdsf8 branch January 26, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb approved these changes

@g-awmalik g-awmalik Awaiting requested review from g-awmalik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apeabody @bharathkkb