fix: omit null defaultValue in bpmetadata #2048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzy-goog
requested review from
bharathkkb,
g-awmalik and
apeabody
as code owners
apeabody
changed the title
g-awmalik
approved these changes
Jan 3, 2024
cli/bpmetadata/tfconfig.go
Outdated
Comment on lines
234
to
238
| if modVar.Default != nil { | ||
| vl, err := structpb.NewValue(modVar.Default) | ||
| if err == nil { | ||
| v.DefaultValue = vl | ||
| } |
There was a problem hiding this comment.
nit: can we make this a bit more left aligned?
Suggested change
| if modVar.Default != nil { | |
| vl, err := structpb.NewValue(modVar.Default) | |
| if err == nil { | |
| v.DefaultValue = vl | |
| } | |
| if modVar.Default == nil { | |
| return v | |
| } | |
| vl, err := structpb.NewValue(modVar.Default) | |
| if err == nil { | |
| v.DefaultValue = vl | |
| } | |
| return v |
g-awmalik
requested changes
Jan 3, 2024
There was a problem hiding this comment.
Please update the version with a patch: https://github.com/rzy-goog/cloud-foundation-toolkit/blob/master/cli/Makefile#L4
g-awmalik
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to b/316180349
Currently, cft blueprint metadata -d appears to set the defaultValue to null if there's no default set in the Terraform file.
This breaks current terraform metadata parsing in g3
This change will omit defaultvalue from being added when null.