Skip to content

Commit

Permalink
fix: removes redundant required field from DisplayVariable (#1959)
Browse files Browse the repository at this point in the history
  • Loading branch information
g-awmalik authored Nov 10, 2023
1 parent 91faee5 commit f23b405
Show file tree
Hide file tree
Showing 4 changed files with 58 additions and 72 deletions.
2 changes: 1 addition & 1 deletion cli/Makefile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
SHELL := /bin/bash

# Changing this value will trigger a new release
VERSION=v1.2.8
VERSION=v1.2.9
BINARY=bin/cft
GITHUB_REPO=github.com/GoogleCloudPlatform/cloud-foundation-toolkit
PLATFORMS := linux windows darwin
Expand Down
120 changes: 55 additions & 65 deletions cli/bpmetadata/bpmetadata_ui.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 2 additions & 3 deletions cli/bpmetadata/proto/bpmetadata_ui.proto
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ message BlueprintUIInput {
// Additional display specific metadata pertaining to a particular
// input variable.
message DisplayVariable {
reserved 19;

// The variable name from the corresponding standard metadata file.
// Gen: auto-generated - the Terraform variable name
string name = 1; // @gotags: json:"name" yaml:"name"
Expand Down Expand Up @@ -112,9 +114,6 @@ message DisplayVariable {
// Optional.
// Gen: manually-authored
int32 level = 18; // @gotags: json:"level,omitempty" yaml:"level,omitempty"

// Whether the property is required for the deployment or not.
bool required = 19; // @gotags: json:"required,omitempty" yaml:"required,omitempty"
}

message ValueLabel {
Expand Down
3 changes: 0 additions & 3 deletions cli/bpmetadata/schema/gcp-blueprint-metadata.json
Original file line number Diff line number Diff line change
Expand Up @@ -711,9 +711,6 @@
},
"level": {
"type": "integer"
},
"required": {
"type": "boolean"
}
},
"additionalProperties": false,
Expand Down

0 comments on commit f23b405

Please sign in to comment.