Skip to content

Commit

Permalink
feat: Add label to DisplayOutput (#2125)
Browse files Browse the repository at this point in the history
  • Loading branch information
gibbleyg authored Feb 5, 2024
1 parent e1f42c8 commit 470e057
Show file tree
Hide file tree
Showing 4 changed files with 31 additions and 12 deletions.
2 changes: 1 addition & 1 deletion cli/Makefile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
SHELL := /bin/bash

# Changing this value will trigger a new release
VERSION=v1.2.15
VERSION=v1.2.16
BINARY=bin/cft
GITHUB_REPO=github.com/GoogleCloudPlatform/cloud-foundation-toolkit
PLATFORMS := linux windows darwin
Expand Down
30 changes: 21 additions & 9 deletions cli/bpmetadata/bpmetadata_ui.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 6 additions & 2 deletions cli/bpmetadata/proto/bpmetadata_ui.proto
Original file line number Diff line number Diff line change
Expand Up @@ -226,14 +226,14 @@ message UIActionItem {
string snippet = 3; // @gotags: json:"snippet,omitempty" yaml:"snippet,omitempty"

// If present, this expression determines whether the item is shown.
// Should be in the form of a Boolean expression e.g. outputs().hasExternalIP
// Should be in the form of a Boolean expression e.g. outputs.hasExternalIP
// where `externalIP` is the output.
// Gen: manually-authored
string show_if = 4; // @gotags: json:"showIf,omitempty" yaml:"showIf,omitempty"
}

// Additional display specific metadata pertaining to a particular
// Terraform output.
// Terraform output. Only applicable for Outputs that are URLs.
message DisplayOutput {
// open_in_new_tab defines if the Output action should be opened
// in a new tab.
Expand All @@ -244,4 +244,8 @@ message DisplayOutput {
// notification for the deployment.
// Gen: manually-authored
bool show_in_notification = 2; // @gotags: json:"showInNotification,omitempty" yaml:"showInNotification,omitempty"

// label to display on the Output action button
// Gen: manually-authored
string label = 3; // @gotags: json:"label,omitempty" yaml:"label,omitEmpty"
}
3 changes: 3 additions & 0 deletions cli/bpmetadata/schema/gcp-blueprint-metadata.json
Original file line number Diff line number Diff line change
Expand Up @@ -652,6 +652,9 @@
},
"showInNotification": {
"type": "boolean"
},
"label": {
"type": "string"
}
},
"additionalProperties": false,
Expand Down

0 comments on commit 470e057

Please sign in to comment.