Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove line that enables Cloud Source Repositories API as this is now deprecated #746

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

alexjmoore
Copy link
Contributor

Fixes #745

Description

Service account creation script in the edge deployment scenario enables the Cloud Source Repositories API which are now deprecated. CSR is not used in the deployment and so this can be removed.

Change summary

  • Removes command to enable CSR API

Related PRs/Issues

@alexjmoore alexjmoore requested review from yoshi-approver and a team as code owners November 15, 2024 17:28
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Nov 15, 2024
@apeabody
Copy link
Collaborator

/gcbrun

@alexjmoore alexjmoore changed the title Remove line that enables Cloud Source Repositories API as this is now deprecated fix: remove line that enables Cloud Source Repositories API as this is now deprecated Nov 15, 2024
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@apeabody
Copy link
Collaborator

FYI: Will probably need #747 merged first for anthos-samples-int-trigger tests.

@apeabody
Copy link
Collaborator

/gcbrun

Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@apeabody apeabody merged commit 36858d1 into GoogleCloudPlatform:main Nov 15, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
2 participants