Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs and integration test for native asyncpg connection pool #382

Open
jackwotherspoon opened this issue Oct 22, 2024 · 1 comment
Open

Add docs and integration test for native asyncpg connection pool #382

jackwotherspoon opened this issue Oct 22, 2024 · 1 comment
Assignees
@rhatgadkar-goog
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: docs Improvement to the documentation for an API.

Comments

@jackwotherspoon
Copy link
Collaborator

Port of GoogleCloudPlatform/cloud-sql-python-connector#1180, we should update async usage guide of README to showcase both SQLAlchemy connection pool and native asyncpg connection pool.

Description

As of asyncpg v0.30.0 it is now possible to pass a custom connection function into the asyncpg.create_pool method, which means it is now possible to use the cloudsql connector without SQLAlchemy, thus maintaining the original API of the asyncpg pool (which is rather important if you are migrating an existing codebase that made heavy use of an asyncpg pool).

Might be helpful to future readers of the docs to reflect that here.

cc @d1manson who contributed this awesome feature to asyncpg 👏
@jackwotherspoon jackwotherspoon added priority: p2 Moderately-important priority. Fix may not be included in next release. type: docs Improvement to the documentation for an API. labels Oct 22, 2024
@jackwotherspoon jackwotherspoon mentioned this issue Oct 25, 2024
Closed
@jackwotherspoon
Copy link
Collaborator Author

FYI: Cloud SQL PR

GoogleCloudPlatform/cloud-sql-python-connector#1182

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rhatgadkar-goog rhatgadkar-goog

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: docs Improvement to the documentation for an API.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jackwotherspoon @rhatgadkar-goog