Add examples of using createWorklet #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 27247a6):
(expires Tue, 05 Nov 2024 16:37:44 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 252501f26f5979e3539be362ca8d2cfd953f75f3 |
taraojo
changed the title
kevinkiklee
approved these changes
Sep 12, 2024
We want to show more uses of the createWorklet method, this example is a straight swap from addModule to createWorklet. In other examples I'll remove the use of the iframe.
I've picked the creative rotation example at random to try out the createWorklet function here. Unlike the previous commit where you can do a straight swap between addModule and createWorklet, in this commit I've removed the iframe completely. As we're relying on the data being managed by the script-origin I've also had to move the seedStorage function into the worklet so it is written into the storage for the content producer instead of the publisher. I've also set a new click handler for the demo controls, this also loads the worklet to ensure we write to Shared Storage with the script- origin. Whenever we request a worklet from a different origin we need to set the headers to allow cors and enable cross origin worklets. As I've removed the iframe, I've moved the controls of the demo into the invoking page directly (using hbs partials). For the sake of the demo I've added the global getContentProducerUrl function to make it easier to check the domain of the content producer within the JS files for getting the worklet and the ads. Also, as the demo is no longer being styled within the iframe I've copied the css styles to the publisher pages.
taraojo
force-pushed
the
createWorklet
branch
from
1a986f8 to
27247a6
Compare
taraojo
changed the title
kevinkiklee
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to show more uses of the
createWorkletfunction, this PR adds 2 examples. The first being a straight swap from addModule tocreateWorkletwithin the iframe and the second usingcreateWorkletwith a cross-origin worklet without the iframe needed.These changes are being added in relation to WICG/shared-storage#158.