This repository has been archived by the owner on Jul 8, 2020. It is now read-only.
add CircleCI support #68
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there anything missing on my end to get this PR merged? |
|
@addyosmani please could you help us with this one? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16
You can test it by installing directly from my branch:
yarn add --dev "https://github.com/erezrokah/lighthousebot#add_circle_ci_support"Also I think there is a bug in the Travis support.
TRAVIS_PULL_REQUEST_SLUGshould beTRAVIS_REPO_SLUG(https://docs.travis-ci.com/user/environment-variables/).I think in case of forks
TRAVIS_PULL_REQUEST_SLUGwill contain the information of the fork, where you actually want to update the current repo status (I'm not sure since I don't use Travis).