Add origin filtering for expose #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamind
commented
Jan 19, 2023
| ep.addEventListener("message", function callback(ev: MessageEvent) { | ||
| if (!ev || !ev.data) { | ||
| return; | ||
| } | ||
| if (!isAllowedOrigin(origins, ev.origin)) { | ||
| console.warn(`Invalid origin '${ev.origin}' for comlink proxy`); |
There was a problem hiding this comment.
Not sure exactly how to handle invalid messages, a warning seems useful, throwing an exception can be pretty hard to handle in this case but also seems more correct. Thoughts @surma ?
There was a problem hiding this comment.
Yeah, I agree with a warning.
surma
approved these changes
Jan 20, 2023
| ep.addEventListener("message", function callback(ev: MessageEvent) { | ||
| if (!ev || !ev.data) { | ||
| return; | ||
| } | ||
| if (!isAllowedOrigin(origins, ev.origin)) { | ||
| console.warn(`Invalid origin '${ev.origin}' for comlink proxy`); |
There was a problem hiding this comment.
Yeah, I agree with a warning.
Co-authored-by: Surma <[email protected]>
|
Hah, @surma it appears you need to sign the Google CLA :-) https://github.com/GoogleChromeLabs/comlink/pull/605/checks?check_run_id=10831963910 |
|
It doesn’t let me add an alternate email address for some reason. But I can override. So Imma go ahead an merge this :) |
This was referenced Jan 24, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for #603 allowing a user to specify an origin filtering regexp/string array to control which origins comlink will listen to.
Not sure if a full fix for #603 would require prevention of prototype changes, but I feel like if you
exposeon window you're always going to be a bit vulnerable unless you specify a filtering origin.