Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear output buffers before calling 'process' #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kazssym
Copy link

@kazssym kazssym commented Aug 26, 2020

The output audio buffer must be zero-filled according to https://webaudio.github.io/web-audio-api/#dom-audioworkletprocessor-process. This patch ensures the output buffers cleared with zeros, I hope.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@kazssym
Copy link
Author

kazssym commented Aug 27, 2020

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@kazssym kazssym changed the title Clear output channels before calling 'process' Clear output buffers before calling 'process' Aug 27, 2020
@kazssym kazssym force-pushed the patch/clear-outputs-before-process branch from 7e5d056 to ceec423 Compare August 27, 2020 05:44
@kazssym kazssym marked this pull request as ready for review August 27, 2020 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants