Fixes HTML encoding in sample #187
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dero
reviewed
Jun 24, 2022
| <source src="av1.mp4" type="video/mp4; codecs=\"av01.0.04M.08\""> | ||
| <source src="hevc.mp4" type="video/mp4; codecs=\"hvc1\""> | ||
| <source src="vp9.mp4" type="video/webm; codecs=\"vp9\""> | ||
| <source src="av1.mp4" type="video/mp4" codecs="av01.0.04M.08"> |
There was a problem hiding this comment.
@PaulKinlan I don't believe codecs is a valid <source> attribute. In this context, codecs is a part of the MIME value and should be delimited by ; from the MIME type.
But you are onto something here. Escaping using \ is not allowed either, AFAIK. We should probably use single quotes around the type attribute value and keep " unescaped.
Like this:
<source src="av1.mp4" type='video/mp4; codecs="av01.0.04M.08"'>
<source src="hevc.mp4" type='video/mp4; codecs="hvc1"'>
<source src="vp9.mp4" type='video/webm; codecs="vp9"'>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Correctly encodes the HTML - this doesn't check the quoted HTML on any other page.
Fixes #186