Only highlight main nav items on exact match. #4401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcscottiii
approved these changes
Sep 27, 2024
| @@ -231,7 +231,7 @@ export class ChromedashDrawer extends LitElement { | |||
| } | |||
|
|
|||
| isCurrentPage(href) { | |||
| return this.currentPage.startsWith(href); | |||
| return this.currentPage === href; | |||
There was a problem hiding this comment.
Something to consider in the future: I think all of the urls on the menu have 0 or 1 query parameters now so it doesn't matter. But if that number grows, we will need to parse the urls and then sort the query string parameters before comparing.
This will help in case a user types in the URL directly into the browser but with the query parameters out of order.
jrobbins
deleted the
20240927-only-highlight-nav-items-on-exact-match
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids the possibility of both "All features" and "Shipping 2024" main menu items both being highlighted at the same time. It also means that the "All features" item will not be highlighted if the user specifies a search term, but that is arguably correct since they are no longer looking at all features.