Dlaliberte playwright 06 22 #3184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Extend devcontainer docker compose file for playwright Create another docker compose file for playwright. That new one extends the existing docker compose Should be able to run: `npm run pwtests` * adjust gh action * adjust gh action * remove volumes * add timeout * fix volumes
* try running as user * again * try * change volume ownership * tidy up
* set script-shell to fix source not found and call npm run setup There has always been `source: not found` in the previous CI jobs The tests previously worked because npm run deps installs the requirements into the default environment and not the virtual environment. And since we actually did not call `source` correctly, it was okay because the default environment had the packages installed. The problem started to arise because we started to call `source` correctly in some places but not all places. This fixes by setting the shell consistently whenever we call `source` More info: https://morgan.cugerone.com/blog/troubleshooting-source-not-found-when-in-the-context-of-package-json-scripts/ * do each separately * Revert "do each separately" This reverts commit 4fc75f7. * do ci job * consistent to the right datastore mode * verbose * kill the emulator * remove verbose
|
One of the hacks/workarounds I did early on was to hide the google login, so it didn't get in the way of logging into the testing account, especially on Firefox where the login dialog always popped up when you were not logged in. But we probably want to allow developers to login to their own account as well, so I'll see if I can reenable the google login, now that we got everything else working. |
jrobbins
reviewed
Sep 6, 2023
jcscottiii
reviewed
Sep 6, 2023
jrobbins
approved these changes
Sep 6, 2023
|
Please give a specific PR summary line. |
Oh well. I did not see that you had merged it already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add initial playwright visual tests.