Skip to content

Commit

Permalink
Update to python 3.11 in GitHub workflows (#4511)
Browse files Browse the repository at this point in the history
* Upgrade fakeredis to v2.26.1

* Update python version in workflows

* restore fakeredis ver

---------

Co-authored-by: Jason Robbins <[email protected]>
  • Loading branch information
cunla and jrobbins authored Nov 1, 2024
1 parent 284c823 commit 4dfd86d
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 20 deletions.
12 changes: 2 additions & 10 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -1,22 +1,14 @@
name: Continuous Integration
# Needed for gcloud because as of Nov 2022, gcloud only supports python 3.5-3.9
# https://cloud.google.com/sdk/docs/install#supported_python_versions
# https://github.com/google-github-actions/setup-gcloud/issues/381#issuecomment-955631107
# ubuntu-20.04 comes with python3.8. As a result, we can tell gcloud to use that.
env:
CLOUDSDK_PYTHON: python3.8
CLOUDSDK_PYTHON: python3.11
on:
push:
branches:
- main
pull_request:
jobs:
python_tests:
# Need to use 20.04 because ubuntu-latest uses ubuntu-22.04.
# 22.04 comes with python 3.10 and that does not work with gcloud.
# https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners
# Refer to CLOUDSDK_PYTHON above for more details.
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4

Expand Down
12 changes: 2 additions & 10 deletions .github/workflows/web_tests.yml
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
name: Continuous Integration Web Tests
# Needed for gcloud because as of Nov 2022, gcloud only supports python 3.5-3.9
# https://cloud.google.com/sdk/docs/install#supported_python_versions
# https://github.com/google-github-actions/setup-gcloud/issues/381#issuecomment-955631107
# ubuntu-20.04 comes with python3.8. As a result, we can tell gcloud to use that.
env:
CLOUDSDK_PYTHON: python3.8
CLOUDSDK_PYTHON: python3.11
on:
push:
branches:
Expand All @@ -13,11 +9,7 @@ on:

jobs:
web_tests:
# Need to use 20.04 because ubuntu-latest uses ubuntu-22.04.
# 22.04 comes with python 3.10 and that does not work with gcloud.
# https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners
# Refer to CLOUDSDK_PYTHON above for more details.
runs-on: ubuntu-20.04
runs-on: ubuntu-latest

strategy:
matrix:
Expand Down

0 comments on commit 4dfd86d

Please sign in to comment.