Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build error: replace logical OR in switch-case with fallthrough #6

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

nikochiko
Copy link
Member

case 'a' || 'b': won't match with either 'a' or 'b', but will match with 'true' because this evaluates
the boolean expression. We want to match either 'a' or 'b', so replaced that with

case 'a':
case 'b':
  doSomething()

Legal Boilerplate

Look, I get it. The entity doing business as “Gooey.AI” and/or “Dara.network” was incorporated in the State of Delaware in 2020 as Dara Network Inc. and is gonna need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Dara Network Inc can use, modify, copy, and redistribute my contributions, under its choice of terms.

@devxpy
Copy link
Member

devxpy commented Sep 23, 2024

Lgtm

@nikochiko nikochiko merged commit 6b7d917 into master Sep 23, 2024
5 checks passed
@nikochiko nikochiko deleted the fix-switch-case branch September 23, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants