Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use max_completion_tokens for o1 models, and max_tokens for the rest #573

Merged
merged 1 commit into from
Dec 24, 2024
Merged

use max_completion_tokens for o1 models, and max_tokens for the rest #573

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions daras_ai_v2/language_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1049,6 +1049,10 @@ def run_openai_chat(
for entry in messages:
if entry["role"] == CHATML_ROLE_SYSTEM:
entry["role"] = CHATML_ROLE_USER
max_tokens = NOT_GIVEN
else:
max_tokens = max_completion_tokens
max_completion_tokens = NOT_GIVEN

if avoid_repetition:
frequency_penalty = 0.1
Expand All @@ -1063,6 +1067,7 @@ def run_openai_chat(
_get_chat_completions_create(
model=model_str,
messages=messages,
max_tokens=max_tokens,
max_completion_tokens=max_completion_tokens,
stop=stop or NOT_GIVEN,
n=num_outputs,
Expand Down
Loading