-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Twilio Botintegration Changes Without UI #400
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devxpy
reviewed
Jul 10, 2024
devxpy
reviewed
Jul 10, 2024
devxpy
reviewed
Jul 10, 2024
devxpy
reviewed
Jul 10, 2024
devxpy
reviewed
Jul 10, 2024
devxpy
reviewed
Jul 10, 2024
devxpy
reviewed
Jul 10, 2024
# Conflicts: # poetry.lock # pyproject.toml
- remove twilio_default_to_gooey_asr, twilio_default_to_gooey_tts - use saved run state to infer it instead - rename twilio_voice -> twilio_tts_voice - rename _unpack_bot_integration -> __init__ - default account sid and auth key to env vars - add indexes for twilio lookups - move BotIntegration.translate -> BotInterface.translate - move twilio payload parsing logic to TwilioVoice Interface - use api base url for twilio redirects - remove slow client.queues.list(), just store the queue instance - delete queue after use - fix broadcast - remove twilio support - avoid un-necessary twilio redirects, directly inline the twiml where possible - use query params for twilio_voice_call_response instead of hacky base64 path params - shuffle waiting audios - fix send_broadcast_msg: specify default arg value for `medium`
@devxpy The default_to_gooey_asr and tts inputs has the downside that people can’t choose to do Twilio ASR/TTS for their Twilio integration and Gooey for other integrations. Twilio is useful since it is a lot faster and because it supports interruptions (Gooey ASR does not) |
use api keys for twilio instead of sid+auth token
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task: https://app.asana.com/0/1203067047205953/1207669871112393
Q/A checklist
You can visualize this using tuna:
To measure import time for a specific library:
To reduce import times, import libraries that take a long time inside the functions that use them instead of at the top of the file:
Legal Boilerplate
Look, I get it. The entity doing business as “Gooey.AI” and/or “Dara.network” was incorporated in the State of Delaware in 2020 as Dara Network Inc. and is gonna need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Dara Network Inc can use, modify, copy, and redistribute my contributions, under its choice of terms.