Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New seamless version! #345

Merged
merged 2 commits into from
Aug 12, 2024
Merged

New seamless version! #345

merged 2 commits into from
Aug 12, 2024

Conversation

SanderGi
Copy link
Member

@SanderGi SanderGi commented Apr 30, 2024

Task: https://app.asana.com/0/1203067047205953/1204911106314540

Q/A checklist

  • If you add new dependencies, did you update the lock file?
poetry lock --no-update
  • Run tests
ulimit -n unlimited && ./scripts/run-tests.sh
  • Do a self code review of the changes - Read the diff at least twice.
  • Carefully think about the stuff that might break because of this change - this sounds obvious but it's easy to forget to do "Go to references" on each function you're changing and see if it's used in a way you didn't expect.
  • The relevant pages still run when you press submit
  • The API for those pages still work (API tab)
  • The public API interface doesn't change if you didn't want it to (check API tab > docs page)
  • Do your UI changes (if applicable) look acceptable on mobile?
  • Ensure you have not regressed the import time unless you have a good reason to do so.
    You can visualize this using tuna:
python3 -X importtime -c 'import server' 2> out.log && tuna out.log

To measure import time for a specific library:

$ time python -c 'import pandas'

________________________________________________________
Executed in    1.15 secs    fish           external
   usr time    2.22 secs   86.00 micros    2.22 secs
   sys time    0.72 secs  613.00 micros    0.72 secs

To reduce import times, import libraries that take a long time inside the functions that use them instead of at the top of the file:

def my_function():
    import pandas as pd
    ...

@SanderGi
Copy link
Member Author

Having some trouble with docker so haven't been able to end2end test, only tested in parts. I'll keep restarting my computer until the daemon launches correctly

SanderGi and others added 2 commits August 12, 2024 23:51
- Replace SEAMLESS_SUPPORTED with SEAMLESS_v2_ASR_SUPPORTED
- Update AsrModels Enum to include seamless_m4t_v2 and mark seamless_m4t as deprecated
- Modify references to use seamless_m4t_v2 model_id and supported languages
- Adjust code for selecting Seamless M4T v2 in relevant functions and scripts
- Auto detect is not technically supported by seamless, so don't allow it
@devxpy devxpy merged commit cb30353 into master Aug 12, 2024
6 checks passed
@devxpy devxpy deleted the seamless_v2 branch August 12, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants