New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix download filename #288

Merged

devxpy merged 3 commits into master from Fix-download-filename

Mar 5, 2024

Contributor

clr-li commented Mar 1, 2024 •

edited

Loading

Asana: https://app.asana.com/0/1203067047205953/1206712161995246

Q/A checklist

Run tests after placing fixutre.json in your project root

ulimit -n unlimited && pytest

Do a self code review of the changes
Carefully think about the stuff that might break because of this change
The relevant pages still run when you press submit
The API for those pages still work (API tab)
The public API interface doesn't change if you didn't want it to (check API tab > docs page)
Do your UI changes (if applicable) look acceptable on mobile?


          Removed #t text

f79b817

clr-li requested a review from devxpy

March 1, 2024 06:17

clr-li added 2 commits

February 29, 2024 22:40


          Better fix

3b1a5b0


          Remove fragment

c5aee2a

devxpy merged commit a20c79e into master

1 of 3 checks passed

devxpy deleted the Fix-download-filename branch

March 5, 2024 15:05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet