Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit hooks: black, trailing whitespace, eof, check-yaml #209

Merged
merged 3 commits into from
Nov 15, 2023

Conversation

nikochiko
Copy link
Member

@nikochiko nikochiko commented Nov 9, 2023

Installation instructions

$ poetry install  # installs pre-commit
$ poetry run pre-commit install

Q/A checklist

  • Do a code review of the changes
  • Add any new dependencies to poetry & export to requirementst.txt (poetry export -o requirements.txt)
  • Carefully think about the stuff that might break because of this change
  • The relevant pages still run when you press submit
  • If you added new settings / knobs, the values get saved if you save it on the UI
  • The API for those pages still work (API tab)
  • The public API interface doesn't change if you didn't want it to (check API tab > docs page)
  • Do your UI changes (if applicable) look acceptable on mobile?

@devxpy
Copy link
Member

devxpy commented Nov 15, 2023

Can you run poetry lock --no-update instead? Auditing the breadth of changes to deps here is frightening

@nikochiko
Copy link
Member Author

Done!

@devxpy devxpy merged commit a388ab5 into master Nov 15, 2023
1 check passed
@devxpy devxpy deleted the black-as-pre-commit branch November 15, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants