Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vCard Improvements #206

Merged
merged 10 commits into from
Dec 4, 2023
Merged

vCard Improvements #206

merged 10 commits into from
Dec 4, 2023

Conversation

SanderGi
Copy link
Member

@SanderGi SanderGi commented Nov 7, 2023

Task: https://app.asana.com/0/1203067047205953/1205752833679516

image

Needs this PR: GooeyAI/gooey-gui#7

Q/A checklist

  • Do a code review of the changes
  • Add any new dependencies to poetry & export to requirementst.txt (poetry export -o requirements.txt)
  • Carefully think about the stuff that might break because of this change
  • The relevant pages still run when you press submit
  • If you added new settings / knobs, the values get saved if you save it on the UI
  • The API for those pages still work (API tab)
  • The public API interface doesn't change if you didn't want it to (check API tab > docs page)
  • Do your UI changes (if applicable) look acceptable on mobile?

@SanderGi SanderGi marked this pull request as draft November 7, 2023 18:53
@SanderGi SanderGi self-assigned this Nov 7, 2023
@SanderGi SanderGi marked this pull request as ready for review November 7, 2023 20:24
@SanderGi SanderGi requested a review from devxpy November 7, 2023 20:24
@devxpy
Copy link
Member

devxpy commented Nov 27, 2023

if we want to merge the ui fix in faster, pls make the seon stuff a different pr cause that will take me more testing before merge

@SanderGi
Copy link
Member Author

if we want to merge the ui fix in faster, pls make the seon stuff a different pr cause that will take me more testing before merge

It has been split. The Seon stuff is now in this PR: #224

recipes/QRCodeGenerator.py Outdated Show resolved Hide resolved
gooey_ui/components.py Outdated Show resolved Hide resolved
gooey_ui/components.py Outdated Show resolved Hide resolved
@SanderGi SanderGi requested a review from devxpy December 3, 2023 08:42
@devxpy devxpy merged commit 34028b8 into master Dec 4, 2023
1 check passed
@devxpy devxpy deleted the vcard_improvements branch December 4, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants