Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowed ffmpeg supported Audio types in ASR input validation #205

Merged
merged 2 commits into from
Nov 12, 2023

Conversation

SanderGi
Copy link
Member

@SanderGi SanderGi commented Nov 7, 2023

Task: https://app.asana.com/0/1203067047205953/1205854628696573

Q/A checklist

  • Do a code review of the changes
  • Add any new dependencies to poetry & export to requirementst.txt (poetry export -o requirements.txt)
  • Carefully think about the stuff that might break because of this change
  • The relevant pages still run when you press submit
  • If you added new settings / knobs, the values get saved if you save it on the UI
  • The API for those pages still work (API tab)
  • The public API interface doesn't change if you didn't want it to (check API tab > docs page)
  • Do your UI changes (if applicable) look acceptable on mobile?

@devxpy
Copy link
Member

devxpy commented Nov 7, 2023

Does the mimetype wildcard work? audio/* & video/*

@SanderGi
Copy link
Member Author

SanderGi commented Nov 7, 2023

Does the mimetype wildcard work? audio/* & video/*

It would, but ffmpeg only supports a subset of all extensions of all audio/video file types so we’d allow users to upload unsupported files

@devxpy
Copy link
Member

devxpy commented Nov 8, 2023

Does the mimetype wildcard work? audio/* & video/*

It would, but ffmpeg only supports a subset of all extensions of all audio/video file types so we’d allow users to upload unsupported files

Better tradeoff than maintaining this list frankly

@SanderGi
Copy link
Member Author

SanderGi commented Nov 9, 2023

Does the mimetype wildcard work? audio/* & video/*

It would, but ffmpeg only supports a subset of all extensions of all audio/video file types so we’d allow users to upload unsupported files

Better tradeoff than maintaining this list frankly

Makes sense. I also had to add "application/octet-stream" since sometimes the browser does not recognize the file type of more exotic files like amr: e349e54. I tested 10 random file types and they all worked

@devxpy devxpy merged commit 2aef351 into master Nov 12, 2023
1 check passed
@devxpy devxpy deleted the asr_filetype_support branch November 12, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants