Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include nice error message in check_wav_audio_format #197

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

SanderGi
Copy link
Member

Before when uploading a corrupted audio file:
image

After:
image

Q/A checklist

  • Do a code review of the changes
  • Add any new dependencies to poetry & export to requirementst.txt (poetry export -o requirements.txt)
  • Carefully think about the stuff that might break because of this change
  • The relevant pages still run when you press submit
  • If you added new settings / knobs, the values get saved if you save it on the UI
  • The API for those pages still work (API tab)
  • The public API interface doesn't change if you didn't want it to (check API tab > docs page)
  • Do your UI changes (if applicable) look acceptable on mobile?

@SanderGi SanderGi requested a review from devxpy October 28, 2023 19:08
@devxpy devxpy merged commit d9a7e48 into master Oct 31, 2023
1 check passed
@devxpy devxpy deleted the fix_asr_audio_check_error_display branch October 31, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants