Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix double quotes in 'People also ask' recipe title #189

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

nikochiko
Copy link
Member

The font was interpreting both double quotes as being the closing
quote.

Before:
image

After:
image

Q/A checklist

  • Do a code review of the changes
  • Add any new dependencies to poetry & export to requirementst.txt (poetry export -o requirements.txt)
  • Carefully think about the stuff that might break because of this change
  • The relevant pages still run when you press submit
  • If you added new settings / knobs, the values get saved if you save it on the UI
  • The API for those pages still work (API tab)
  • The public API interface doesn't change if you didn't want it to (check API tab > docs page)
  • Do your UI changes (if applicable) look acceptable on mobile?

The font was interpreting both double quotes as being the closing
quote.
@devxpy devxpy merged commit 7285027 into master Oct 25, 2023
1 check passed
@devxpy devxpy deleted the double-quotes-font branch October 25, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants