Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save price to saved run #177

Merged
merged 12 commits into from
Oct 12, 2023
Merged

Save price to saved run #177

merged 12 commits into from
Oct 12, 2023

Conversation

clr-li
Copy link
Contributor

@clr-li clr-li commented Oct 10, 2023

Asana: https://app.asana.com/0/1203067047205953/1205645652925629

Screen Shot 2023-10-09 at 10 57 07 PM

Q/A checklist

  • Do a code review of the changes
  • Add any new dependencies to poetry & export to requirementst.txt (poetry export -o requirements.txt)
  • Carefully think about the stuff that might break because of this change
  • The relevant pages still run when you press submit
  • If you added new settings / knobs, the values get saved if you save it on the UI
  • The API for those pages still work (API tab)
  • The public API interface doesn't change if you didn't want it to (check API tab > docs page)
  • Do your UI changes (if applicable) look acceptable on mobile?

@clr-li clr-li requested a review from devxpy October 11, 2023 03:56
bots/models.py Show resolved Hide resolved
Procfile Outdated Show resolved Hide resolved
@devxpy devxpy merged commit ec2f5af into master Oct 12, 2023
@devxpy devxpy deleted the save_price branch February 12, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants