Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: qr-code: preserve state when switching between input modes #174

Closed
wants to merge 2 commits into from

Conversation

nikochiko
Copy link
Member

input modes: text/url, image, and (wip) vcard

Q/A checklist

  • Do a code review of the changes
  • Add any new dependencies to poetry & export to requirementst.txt (poetry export -o requirements.txt)
  • Carefully think about the stuff that might break because of this change
  • The relevant pages still run when you press submit
  • If you added new settings / knobs, the values get saved if you save it on the UI
  • The API for those pages still work (API tab)
  • The public API interface doesn't change if you didn't want it to (check API tab > docs page)
  • Do your UI changes (if applicable) look acceptable on mobile?

@devxpy devxpy added the blocked label Oct 12, 2023
@devxpy
Copy link
Member

devxpy commented Oct 18, 2023

This has been implemented in another commit to account for the new fields, thanks for the idea!

https://github.com/dara-network/gooey-server/blob/00dac8de55463500ba920bcc0c49258417de96e0/recipes/QRCodeGenerator.py#L526

@devxpy devxpy closed this Oct 18, 2023
@nikochiko nikochiko deleted the qrcode-none-bug branch May 30, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants