Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QR Code vCard #172

Closed
wants to merge 0 commits into from
Closed

QR Code vCard #172

wants to merge 0 commits into from

Conversation

SanderGi
Copy link
Member

@SanderGi SanderGi commented Oct 3, 2023 •
edited
Loading

Task: https://app.asana.com/0/1203067047205953/1205752833679516

Q/A checklist

  • Do a code review of the changes
  • Add any new dependencies to poetry & export to requirementst.txt (poetry export -o requirements.txt)
  • Carefully think about the stuff that might break because of this change
  • The relevant pages still run when you press submit
  • If you added new settings / knobs, the values get saved if you save it on the UI
  • The API for those pages still work (API tab)
  • The public API interface doesn't change if you didn't want it to (check API tab > docs page)
  • Do your UI changes (if applicable) look acceptable on mobile?

@SanderGi SanderGi requested a review from devxpy October 3, 2023 08:01
@SanderGi SanderGi mentioned this pull request Oct 4, 2023
Merged
@SanderGi
Copy link
Member Author

SanderGi commented Oct 4, 2023

Needs this PR: GooeyAI/gooey-gui#7

@SanderGi
Copy link
Member Author

I have moved the Apollo API key into the .env file from previously being hardcode in the email recipe.

APOLLO_API_KEY=[hidden]

@devxpy devxpy closed this Oct 26, 2023
@SanderGi SanderGi changed the title QR Code vCards QR Code vCard Improvements Nov 7, 2023
@SanderGi SanderGi reopened this Nov 7, 2023
@SanderGi SanderGi marked this pull request as draft November 7, 2023 18:39
@SanderGi SanderGi self-assigned this Nov 7, 2023
@SanderGi SanderGi closed this Nov 7, 2023
@SanderGi SanderGi deleted the QR-vcard branch November 7, 2023 18:44
@SanderGi SanderGi changed the title QR Code vCard Improvements QR Code vCard Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devxpy devxpy Awaiting requested review from devxpy

Assignees

@SanderGi SanderGi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SanderGi @devxpy