-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slack: Use Member Join Event instead of Message #167
Conversation
Have you updated the manifests for dev and prod apps and made sure they are backwards compact for existing integrations? |
Just added it to the prod app manifest - dev app is already set. It was backwards compatible for the test channels I had so should be fine for all existing integrations. This is a very minor change to listen to an event that would otherwise be ignored. |
Did you test this PR before submitting it? |
It looks like the slack event is this:
Which throws this key error - https://dara-network.sentry.io/issues/4507231400/?project=4504338635423744&query=is%3Aunresolved&referrer=issue-stream&stream_index=0 |
Weird. I did test it and it worked locally. Lmk take a look at it again |
Edit: I see you already fixed it |
I think I figured out what went wrong: I had both the prod app and dev app integrated to the same channel and saw the prod app working but thought it was the dev app 🤦♂️. Won't happen again |
Changes outlined in this task:
https://app.asana.com/0/1203067047205953/1205542154436394
The production app will need the "member_joined_channel" event added to the "bot_events" section of the "settings" section of the app manifest:
Q/A checklist
poetry export -o requirements.txt
)