Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple asr models at the same time #164

Closed
wants to merge 36 commits into from
Closed

Conversation

SanderGi
Copy link
Member

Enum_multiselect for asr models:
image

The intersection of supported languages is automatically used to limit the options in the User Language selector.

Q/A checklist

  • Do a code review of the changes
  • Add any new dependencies to poetry & export to requirementst.txt (poetry export -o requirements.txt)
  • Carefully think about the stuff that might break because of this change
  • The relevant pages still run when you press submit
  • If you added new settings / knobs, the values get saved if you save it on the UI
  • The API for those pages still work (API tab)
  • The public API interface doesn't change if you didn't want it to (check API tab > docs page)
  • Do your UI changes (if applicable) look acceptable on mobile?

@SanderGi
Copy link
Member Author

Since the ASR recipe inherently supports multiple documents and now also supports multiple models, maybe I don't need the bulk runner for the ASR evaluator?

@SanderGi SanderGi requested a review from devxpy September 20, 2023 20:57
@devxpy
Copy link
Member

devxpy commented Sep 25, 2023

Please ensure backwards compat with api users that use selected_model and also with examples that use selected_model

@SanderGi SanderGi mentioned this pull request Sep 26, 2023
8 tasks
nikochiko and others added 25 commits October 5, 2023 19:36
Starting all services in different terminals is tedious. This PR adds
a Procfile and a honcho dependency that will start up all required
processes in a single command.
This makes it compatible with devs that use other shells
…ces for redis/rabbitmq over honcho

The local dev setup fails with fixtures when run with SQLite, but works
fine with postgresql. This could be due to some constraints that postgres
enforces but not sqlite. It's also better to use postgres for local dev
too because that would be consistent with production environment.
The other change is preferring background services for redis/rabbitmq
over starting them through honcho. This is because starting/stopping them
takes longer, especially for rabbitmq. Honcho should be quick to start and
stop. This also makes sure that task results persist in Redis and unprocessed
tasks persist in RabbitMQ over honcho restarts.
@devxpy
Copy link
Member

devxpy commented Oct 12, 2023

Closing this for now as per earlier discussion, will reopen as needed

@devxpy devxpy closed this Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants