Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in bots/models.py: comapre -> compare #161

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Conversation

nikochiko
Copy link
Member

This typo was only visible in the admin dashboard where a workflow needs to
be selected. The migration is also of no consequence because the altered field
only stores the integer value and not the text representations of the integer
choice.

Q/A checklist

  • Do a code review of the changes
  • Add any new dependencies to poetry & export to requirementst.txt (poetry export -o requirements.txt)
  • Carefully think about the stuff that might break because of this change
  • The relevant pages still run when you press submit
  • If you added new settings / knobs, the values get saved if you save it on the UI
  • The API for those pages still work (API tab)
  • The public API interface doesn't change if you didn't want it to (check API tab > docs page)
  • Do your UI changes (if applicable) look acceptable on mobile?

This typo was only visible in the admin dashboard where a workflow needs to
be selected. The migration is also of no consequence because the altered field
only stores the integer value and not the text representations of the integer
choice.
@nikochiko nikochiko changed the title y Fix typo in bots/models.py: comapre -> compare Sep 20, 2023
@devxpy devxpy merged commit 34f324b into master Sep 20, 2023
@devxpy devxpy deleted the fix-typo-modelspy branch September 20, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants