Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qr v2 #136

Closed
wants to merge 16 commits into from
Closed

Qr v2 #136

wants to merge 16 commits into from

Conversation

SanderGi
Copy link
Member

Implemented changes described in https://app.asana.com/0/1204877873299526/1205091630858490

Q/A checklist

  • Do a code review of the changes
  • Add any new dependencies to poetry & export to requirementst.txt (poetry export -o requirements.txt)
  • Carefully think about the stuff that might break because of this change
  • The relevant pages still run when you press submit
  • If you added new settings / knobs, the values get saved if you save it on the UI
  • The API for those pages still work (API tab)
  • The public API interface doesn't change if you didn't want it to (check API tab > docs page)
  • Do your UI changes (if applicable) look acceptable on mobile?

@SanderGi
Copy link
Member Author

Here is the GPU PR: GooeyAI/gooey-gpu#2

@SanderGi
Copy link
Member Author

I'll update the defaults on firebase once this PR is deployed, since changing the controlnet beforehand would make it invalid

@SanderGi
Copy link
Member Author

I don't seem to have the right hyper-parameters for QR Monster V2

Before:
image
After:

Usually we see abominations like this that don't scan:
image

@SanderGi SanderGi requested a review from devxpy July 25, 2023 08:14
@SanderGi
Copy link
Member Author

SanderGi commented Jul 26, 2023

Added setting presets:
image7e2bf574)

"Beautiful" is a good candidate for the new default setting in firebase. It is QR monster but with brightness controlnet to make sure it always scans by enforcing sufficient contrast

@SanderGi
Copy link
Member Author

image
Version with buttons instead of radio buttons relies on this PR: GooeyAI/gooey-gui#3

@devxpy devxpy closed this Aug 3, 2023
@SanderGi
Copy link
Member Author

SanderGi commented Aug 5, 2023

Why is this closed? I thought we would still at the qr monster v2 but without the presets?

@devxpy
Copy link
Member

devxpy commented Aug 29, 2023

Yes, I thought you were going to do another PR

@devxpy devxpy reopened this Aug 29, 2023
@devxpy devxpy closed this Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants