add gcp_project gcp_region env vars

GooeyAI · Jun 26, 2024 · 8d4e4fb · 8d4e4fb
1 parent 4330466
commit 8d4e4fb
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 3 deletions.
diff --git a/.env.example b/.env.example
@@ -2,6 +2,8 @@ APP_BASE_URL=http://localhost:3000
 API_BASE_URL=http://localhost:8080
 ADMIN_BASE_URL=http://localhost:8000
 
+GCP_PROJECT=dara-c1b52
+GCP_REGION=us-central1
 GS_BUCKET_NAME=dara-c1b52.appspot.com
 
 PGHOST=127.0.0.1

diff --git a/.github/workflows/python-tests.yml b/.github/workflows/python-tests.yml
@@ -81,8 +81,10 @@ jobs:
           APP_BASE_URL: http://localhost:3000
           API_BASE_URL: http://localhost:8080
           ADMIN_BASE_URL: http://localhost:8000
+          GCP_PROJECT: ${{ env.GCP_PROJECT }}
+          GCP_REGION: $${{ env.GCP_REGION }}
+          GS_BUCKET_NAME: $${{ env.GS_BUCKET_NAME }}
           GOOGLE_APPLICATION_CREDENTIALS_JSON: ${{ secrets.GOOGLE_APPLICATION_CREDENTIALS_JSON }}
-          GS_BUCKET_NAME: ${{ secrets.GS_BUCKET_NAME }}
           STRIPE_SECRET_KEY: ${{ secrets.STRIPE_SECRET_KEY }}
           ELEVEN_LABS_API_KEY: ${{ secrets.ELEVEN_LABS_API_KEY }}
           AZURE_SPEECH_REGION: ${{ secrets.AZURE_SPEECH_REGION }}

diff --git a/README.md b/README.md
@@ -33,6 +33,7 @@
    - Firebase Authentication Admin
    - Storage Admin
 5. Create and Download a JSON Key for this service account and save it to the project root as `serviceAccountKey.json`.
+6. Add your project & bucket name to `.env`
 
 * Run tests to see if everything is working fine:
   ``` 

diff --git a/daras_ai_v2/settings.py b/daras_ai_v2/settings.py
@@ -226,8 +226,7 @@
 
 GCP_PROJECT = config("GCP_PROJECT", default="dara-c1b52")
 GCP_REGION = config("GCP_REGION", default="us-central1")
-
-GS_BUCKET_NAME = config("GS_BUCKET_NAME", default="")
+GS_BUCKET_NAME = config("GS_BUCKET_NAME", default="dara-c1b52.appspot.com")
 GS_MEDIA_PATH = config("GS_MEDIA_PATH", default="daras_ai/media")
 
 GOOGLE_CLIENT_ID = config("GOOGLE_CLIENT_ID", default="")