-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
4 changed files
with
34 additions
and
32 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,12 @@ | ||
### Q/A checklist | ||
|
||
- [ ] Do a code review of the changes | ||
- [ ] Add any new dependencies to poetry & export to requirementst.txt (`poetry export -o requirements.txt`) | ||
- [ ] Run tests after placing [fixutre.json](https://storage.googleapis.com/dara-c1b52.appspot.com/daras_ai/media/ca0f13b8-d6ed-11ee-870b-8e93953183bb/fixture.json) in your project root | ||
```bash | ||
ulimit -n unlimited && pytest | ||
``` | ||
- [ ] Do a self code review of the changes | ||
- [ ] Carefully think about the stuff that might break because of this change | ||
- [ ] The relevant pages still run when you press submit | ||
- [ ] If you added new settings / knobs, the values get saved if you save it on the UI | ||
- [ ] The API for those pages still work (API tab) | ||
- [ ] The public API interface doesn't change if you didn't want it to (check API tab > docs page) | ||
- [ ] Do your UI changes (if applicable) look acceptable on mobile? |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters