Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NA - Update auctions ending soon threshold #926

Merged
merged 2 commits into from
Apr 30, 2024
Merged

NA - Update auctions ending soon threshold #926

merged 2 commits into from
Apr 30, 2024

Conversation

jaspercroome
Copy link
Contributor

Summary

Slight adjustment of the 'auction ending soon' logic:

  • increase window from 60-115 minutes to 60-120 minutes
  • add <= to eval logic

before these changes, auctions would be excluded if they met this criteria when the check ran:

  • they had exactly 60 minutes left
  • they had 115.01 --> 120 minutes left. These would also be missed in the subsequent check since they'd be under 60 minutes the next time it ran

@jaspercroome jaspercroome requested a review from bd-viget April 26, 2024 13:29
bd-viget
bd-viget approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@bd-viget bd-viget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little bit of recommended clean-up here, but otherwise, ready to ship! 🚢

client-mu-plugins/goodbids/src/classes/Auctions/Auction.php Outdated Show resolved Hide resolved
client-mu-plugins/goodbids/src/classes/Auctions/Auction.php Outdated Show resolved Hide resolved
client-mu-plugins/goodbids/src/classes/Auctions/Auction.php Outdated Show resolved Hide resolved
client-mu-plugins/goodbids/src/classes/Auctions/Auction.php Outdated Show resolved Hide resolved
@jaspercroome jaspercroome force-pushed the jc/maximize-interval branch from d7bd55c to 90fd4d4 Compare April 30, 2024 03:50
@jaspercroome jaspercroome merged commit 26f2829 into main Apr 30, 2024
1 check passed
@jaspercroome jaspercroome deleted the jc/maximize-interval branch April 30, 2024 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bd-viget bd-viget bd-viget approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaspercroome @bd-viget