Jester Role #49
Jester Role #49
Conversation
Content.Server/_SSS/SuspicionGameRule/SuspicionRuleSystem.Spawning.cs
Outdated
Show resolved
Hide resolved
| RaiseNetworkEvent(new SuspicionRuleUpdateRole(SuspicionRole.Detective), ownedEntity.Value); | ||
| participatingPlayers.Remove(role); |
There was a problem hiding this comment.
I feel like we should probably pull out some of the systems here (such as the briefing and shit) so we don't duplicated code like crazy.
There was a problem hiding this comment.
We really should, but like I said, I'm not trying to refactor everything with this PR.
| victory = "Jesters"; | ||
| break; | ||
|
|
||
| case var _ when innocentsOnlyAlive.Count + detectivesOnlyAlive.Count == 0: | ||
| victory = "Traitors"; | ||
| break; | ||
|
|
||
| default: | ||
| victory = "Innocents"; |
There was a problem hiding this comment.
While my previous shitcode is not localized, new code probably should be.
There was a problem hiding this comment.
This is still shitcode, just slightly better shitcode. I plan on having the summary text be generated by the win condition, not just hope that we get the right win condition. Future me/us problem.
| /// Percentage of total players that will be a wildcard role. Handled similar to traitor percentage (rounded down etc). | ||
| /// </summary> | ||
| public static readonly CVarDef<float> SSSWildcardPercentage = | ||
| CVarDef.Create("sss.wildcard_percentage", 0.15f, CVar.SERVERONLY); | ||
|
|
||
| /// <summary> | ||
| /// Chance a round will include wildcard roles. | ||
| /// </summary> | ||
| public static readonly CVarDef<float> SSSWildcardChance = | ||
| CVarDef.Create("sss.wildcard_chance", 0.3f, CVar.SERVERONLY); | ||
| /// <summary> |
There was a problem hiding this comment.
There should probably be a minimum CVar for subroles to appear so that rounds with less than X players don't get too wild.
There was a problem hiding this comment.
I think we should leave it as is for now, so we can get feedback on new roles, and if it becomes a problem in the future its easy enough to add in.
Content.Server/_SSS/SuspicionGameRule/SuspicionRuleSystem.Utility.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Simon <[email protected]>
|
no like seriously tho most of SSS gamerule will have to be refactored in the near future anyway |
we should like nuke it |
Yes! |
|
fuck it, we ball |
About the PR
Adds the jester role, whose job is to try and get killed.
Why / Balance
Fun
Technical details
so like, everything really should be in prototypes and shit but id have to refactor a lot of SSS existing code, and I don't feel like that right now. i just shit coded on top of simyon's shitcode.
Changelog
🆑