Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Unnecessary Roles #42

Merged
merged 4 commits into from
Dec 17, 2024

Conversation

sleepyyapril
Copy link
Contributor

@sleepyyapril sleepyyapril commented Dec 17, 2024

About the PR

Hides the unused roles from the preference list. Should probably reset preferences too so people don't fuck themself over permanently.

Media

image

Changelog

🆑

  • tweak: Fixed other roles showing up in selection.

@github-actions github-actions bot added size/S and removed size/XS labels Dec 17, 2024
@github-actions github-actions bot added size/M and removed size/S labels Dec 17, 2024
@sleepyyapril
Copy link
Contributor Author

last test fail was because it was checking if jobs that were in a map had SetPreference (hiding in preferences) set to false. we don't really care about that test and I think this is far easier than removing the jobs from the maps.

@Simyon264 Simyon264 merged commit 086006d into Goob-Station:master Dec 17, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants